Fix NPE on goto to invalid method reference#9210
Open
mbien wants to merge 1 commit intoapache:masterfrom
Open
Conversation
mbien
added
Java
mbien
commented
Feb 17, 2026
Comment on lines
482
to
483
| if (peer.getKind() == ElementKind.RECORD_COMPONENT) { | ||
| for (RecordComponentElement component : ((TypeElement)peer.getEnclosingElement()).getRecordComponents()) { |
Contributor
There was a problem hiding this comment.
I think it mostly is OK. And it basically weakly suggests that peer.getEnclosingElement() == enclosing, which should be always true. (I probably would just do enclosing.getEnclosingElement(), though.)
I wonder if it is possible to write a test for this - I can try at some point if needed.
Otherwise - great cleanup, thanks for doing this!
Member
Author
There was a problem hiding this comment.
(I probably would just do enclosing.getEnclosingElement(), though.)
you mean changing
for (RecordComponentElement component : ((TypeElement)peer.getEnclosingElement()).getRecordComponents()) {into
for (RecordComponentElement component : ((TypeElement)enclosing).getRecordComponents()) {good idea,
Member
Author
There was a problem hiding this comment.
added regression test and updated the logic so that it breaks out of both loops instead of just the inner loop.
- check if element is a record before listing components - removed reflective method calls and updated logic - added regression test
mbien
force-pushed
the
goto-invalid-method-reference
branch
from
712cb66 to
ce2ac52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reproducer:
fixes #8735